From 59f6a8d8716e01f54ad2c6e6298068e1f1848195 Mon Sep 17 00:00:00 2001 From: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com> Date: Tue, 26 Nov 2024 10:42:19 -0500 Subject: [PATCH] STY: code review --- .gitignore | 2 +- pysatNASA/instruments/methods/__init__.py | 2 +- pysatNASA/instruments/methods/mgs.py | 1 - pysatNASA/instruments/mgs_mag.py | 5 ++--- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index e409e395..739b4521 100644 --- a/.gitignore +++ b/.gitignore @@ -76,4 +76,4 @@ custom_lint.sh .vscode # pyenv -.python-version \ No newline at end of file +.python-version diff --git a/pysatNASA/instruments/methods/__init__.py b/pysatNASA/instruments/methods/__init__.py index 8a0039d4..76b33971 100644 --- a/pysatNASA/instruments/methods/__init__.py +++ b/pysatNASA/instruments/methods/__init__.py @@ -24,4 +24,4 @@ from pysatNASA.instruments.methods import reach # noqa F401 from pysatNASA.instruments.methods import ses14 # noqa F401 from pysatNASA.instruments.methods import timed # noqa F401 -from pysatNASA.instruments.methods import mgs # noqa F401 \ No newline at end of file +from pysatNASA.instruments.methods import mgs # noqa F401 diff --git a/pysatNASA/instruments/methods/mgs.py b/pysatNASA/instruments/methods/mgs.py index c073afb9..89a37e1a 100644 --- a/pysatNASA/instruments/methods/mgs.py +++ b/pysatNASA/instruments/methods/mgs.py @@ -1,7 +1,6 @@ #!/usr/bin/env python # -*- coding: utf-8 -*- # -# TODO(#XXX): Update NRL review before next version release # --------------------------------------------------------- """Provides non-instrument specific routines for MGS data.""" diff --git a/pysatNASA/instruments/mgs_mag.py b/pysatNASA/instruments/mgs_mag.py index c38d9c8e..108f773c 100644 --- a/pysatNASA/instruments/mgs_mag.py +++ b/pysatNASA/instruments/mgs_mag.py @@ -1,7 +1,6 @@ #!/usr/bin/env python # -*- coding: utf-8 -*- # -# TODO(#XXX): Update NRL review before next version release # --------------------------------------------------------- """Module for the MGS mag instrument. @@ -99,7 +98,7 @@ # Set the load routine -def load(fnames, tag=None, inst_id=None): +def load(fnames, tag='', inst_id=''): """Load MGS MAG data into `pandas.DataFrame` and `pysat.Meta` objects. This routine is called as needed by pysat. It is not intended @@ -114,7 +113,7 @@ def load(fnames, tag=None, inst_id=None): tag name used to identify particular data set to be loaded. This input is nominally provided by pysat itself. inst_id : str - Satellite ID used to identify particular data set to be loaded. + Instrument ID used to identify particular data set to be loaded. This input is nominally provided by pysat itself. Returns