Merge pull request #1537 from pypeit/s3_url_hotfix

HOTFIX: Add correct exception to ``pypeit.data._get_s3_hostname()``
pypeit · Feb 17, 2023 · c805de2 · c805de2
2 parents a4777c6 + 6878f66
commit c805de2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,6 +4,8 @@
 
 - (Hotfix) Specify sphinx versions to correctly work with
   sphinx_rtd_theme
+- (Hotfix) Fixed bug that caused crash of sensfunc routines using
+  telluric grids in offline processing
 - (Hotfix) Fixed error when showing flats in Ginga when the fine correction is not performed
 - Implemented the upgraded GTC/OSIRIS+
 - (Hotfix) keymap error when displaying GUIs

diff --git a/pypeit/data/utils.py b/pypeit/data/utils.py
@@ -69,7 +69,7 @@
 """
 import os
 import shutil
-import urllib
+import urllib.error
 
 import astropy.utils.data
 import github
@@ -695,7 +695,12 @@ def _get_s3_hostname():
         filepath = astropy.utils.data.download_file(
             remote_url, cache="update", timeout=10, pkgname="pypeit"
         )
-    except (urllib.error.URLError, github.GithubException):
+    except (
+        requests.exceptions.ConnectionError,
+        requests.exceptions.RequestException,
+        urllib.error.URLError,
+        github.GithubException
+    ):
         filepath = os.path.join(Paths.data, "s3_url.txt")
 
     # Open the file and return the URL