Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sytax error in issue #68 #69

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fixing sytax error in issue #68 #69

merged 1 commit into from
Oct 13, 2023

Conversation

ftherrien
Copy link
Member

No description provided.

@ftherrien
Copy link
Member Author

@vstevano we need to spend some time fixing these automatic tests so that we can actually use them to confirm everything works.

Here is the result when I run these tests locally:

================================== short test summary info ===================================
FAILED tests/decorations/test_defects.py::test_iterator - AttributeError: 'pylada.decorations._decorations.FCIterator' object has no attribute '_FC...
FAILED tests/decorations/test_fciterator.py::test_fciterator - AttributeError: 'pylada.decorations._decorations.FCIterator' object has no attribute '_FC...
FAILED tests/espresso/test_extract.py::test_cellshape - AssertionError: assert False
FAILED tests/espresso/test_pwscf.py::test_iteration - TypeError: __init__() got an unexpected keyword argument 'prefix'
FAILED tests/espresso/bdd/test_restart.py::test_check_restart_input - pylada.error.RuntimeError: Cannot restart from unsuccessful calculation
FAILED tests/espresso/bdd/test_restart.py::test_check_restarted_run - pylada.error.RuntimeError: Cannot restart from unsuccessful calculation
============= 6 failed, 475 passed, 35 skipped, 58 warnings in 74.74s (0:01:14) ==============

A lot of them are relevant to QE so you or Matt should take a look at them.

@ftherrien
Copy link
Member Author

I will merge this PR so that importing pylada works, but I will create an issue about the tests failing

@ftherrien ftherrien merged commit aade657 into master Oct 13, 2023
0 of 3 checks passed
@ftherrien ftherrien deleted the fix_68 branch October 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant