Support pin_memory() in Multi{Embedding,Nested}Tensor and TensorFrame
#437
+83
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
force-pushed
the
aki-pin-memory
branch
from
1d897d0 to
8b209bb
Compare
akihironitta
force-pushed
the
aki-pin-memory
branch
from
8b209bb to
e3c36ca
Compare
akihironitta
changed the title
Multi{Embedding,Nested}Tensor.pin_memory() and TensorFrame.pin_memory()pin_memory() in Multi{Embedding,Nested}Tensor and TensorFrame
akihironitta
force-pushed
the
aki-pin-memory
branch
from
e3c36ca to
e1b98de
Compare
akihironitta
commented
Aug 19, 2024
There was a problem hiding this comment.
It's useful for moving data to GPU faster: https://pytorch.org/docs/stable/data.html#memory-pinning :)
zechengz
approved these changes
Aug 20, 2024
Co-authored-by: Zecheng Zhang <[email protected]>
akihironitta
commented
Aug 20, 2024
|
are we merging this? Why there are a lot of test failures? |
|
Will be merging this PR once the CI becomes green 🟢 Let me know if anyone has any review comments on this PR as I'm happy to address any concerns or elaborate on the change in this PR :) |
akihironitta
commented
Dec 30, 2024
Comment on lines
+98
to
+99
| @onlyCUDA | ||
| def test_basics(device): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.