Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the image of the architecture overview in our documentation #288

Open
akihironitta opened this issue Dec 11, 2023 · 2 comments
Open

Comments

@akihironitta
Copy link
Member

If I understand it correctly, the image below doesn't reflect our current structure precisely because the output of FeatureEncoder should be a concatenated tensor. However, the image illustrates that the concatenation is applied outside the FeatureEncoder.

@yiweny
Copy link
Contributor

yiweny commented Dec 11, 2023

The concatenation is done by the StypeWiseFeatureEncoder after applying each StypeEncoder to each stype. Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together, we can defer this task till then.

@akihironitta
Copy link
Member Author

@yiweny Thanks, I agree that this is not urgent.

Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together

Still, it might be better to have a consistent interface to make other parts of PyF models FeatureEncoder-agnostic, which contributes to the modular design of PyF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants