You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand it correctly, the image below doesn't reflect our current structure precisely because the output of FeatureEncoder should be a concatenated tensor. However, the image illustrates that the concatenation is applied outside the FeatureEncoder.
The text was updated successfully, but these errors were encountered:
The concatenation is done by the StypeWiseFeatureEncoder after applying each StypeEncoder to each stype. Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together, we can defer this task till then.
Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together
Still, it might be better to have a consistent interface to make other parts of PyF models FeatureEncoder-agnostic, which contributes to the modular design of PyF.
If I understand it correctly, the image below doesn't reflect our current structure precisely because the output of
FeatureEncoder
should be a concatenated tensor. However, the image illustrates that the concatenation is applied outside theFeatureEncoder
.The text was updated successfully, but these errors were encountered: