Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CSS minifier backend to lightningcss #33

Closed
pydsigner opened this issue Aug 9, 2023 · 1 comment · Fixed by #38
Closed

Switch CSS minifier backend to lightningcss #33

pydsigner opened this issue Aug 9, 2023 · 1 comment · Fixed by #38
Labels
bug Something isn't working
Milestone
0.11.0

Comments

@pydsigner
Copy link
Owner

Depending on how quickly attention is given to issues like sprymix/csscompressor#13, sprymix/csscompressor#14, and sprymix/csscompressor#9, we may wish to vendor a custom version of csscompressor for our minification.

See also #32, which this would really require.
@pydsigner pydsigner added the bug Something isn't working label Aug 9, 2023
@pydsigner
Copy link
Owner Author

lightningcss can offer more useful functionality, and works out of the box (apart from needing Rust bindings). We'll use python-lightningcss instead.

@pydsigner pydsigner changed the title Consider vendoring css minifier Switch CSS minifier backend to lightningcss Aug 11, 2023
@pydsigner pydsigner added this to the 0.11.0 milestone Aug 11, 2023
pydsigner added a commit that referenced this issue Aug 11, 2023
@pydsigner
Switch to lightningcss from csscompressor (#33)
3bcad39
@pydsigner pydsigner linked a pull request Nov 18, 2023 that will close this issue
General enhancements #38
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

General enhancements pydsigner/anchovy
1 participant
@pydsigner