ListedColormap: don't pass N colors #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's actually also mentioned in #9810 (maybe because internal warnings now error?) |
mathause
commented
Nov 22, 2024
| @@ -1806,7 +1806,6 @@ def test_colors_np_levels(self) -> None: | |||
| cmap = artist.cmap | |||
| assert isinstance(cmap, mpl.colors.ListedColormap) | |||
| colors = cmap.colors | |||
| assert isinstance(colors, list) | |||
There was a problem hiding this comment.
That's now an numpy array. I am reasonably sure that is a behaviour change in matplotlib and I don't think we should try to preserve that.
There was a problem hiding this comment.
I think the instance check was only there to make mypy happy. We don't really care what type colors is, as long as it is indexable.
|
remaining failures are unrelated |
|
Thanks for taking this on! |
This was referenced Nov 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rstmatplotlib/matplotlib#29135 deprecated passing
NtoListedColormap. This PR avoids the deprecation warnings once the new matplotlib version is released.