Remove x509 ABCs

[alex]

In numerous places we only support the concrete classes, and there's no real use case for people to implement the ABCs themselves.

Therefore, we should just drop the ABCs, and replace them with the concrete base classes.

Tasks

Beta Give feedback

1. SignedCertificateTimestamp remove sct abc #11995
2. Certificate remove Certificate abc #11989
3. RevokedCertificate
4. CertificateRevocationList remove crl abc #11991
5. CertificateSigningRequest remove csr abc #11994
6. OCSPRequest remove OCSPRequest abc #11990
7. OCSPSingleResponse remove OCSPSingleResponse abc #11993
8. OCSPResponse remove OCSPResponse abc #11992

[TreavVasu]

Hi @alex
Is this up for taking?

How I plan to implement this:

Taking Certificate class as an example :

Link to class

class Certificate(metaclass=abc.ABCMeta):

Removing (metaclass=abc.ABCMeta) and adding it as new-style class
class Certificate:

Addressing the changes further:

Remove @abc.abstractmethod Decorators

then

Remove @abc.abstractproperty with @property

then
Retain Property Decorators (@Property) Where Needed

I am bit confused on how to Implement methods and properties here should return as here of find the linked function it sounds a bit ddumb I know but I think with little direction I can pull this off.

Let me know if I am missing something or wrong somewhere, I'll try to cover those cases again and revert back
Thanks for reading

[alex]

We'd be happy to take contributions for this yes!

In terms of what needs to be done: These classes need to be deleted, and the concrete implementations should be exposed with the same name, and then we have to make sure the mypy types work correctly for them.

(With teh small asterisk that RevokedCertificate is more complicated, and should be saved for last.)

[TreavVasu]

Thanks @alex
I'll try my best

Sure, I hope you can help me on places where RevokedCertificate gets too complex :)

[alex]

Please do each of these in separate pull requests, not one big one.

…

On Fri, Oct 18, 2024 at 5:09 PM treavvasu ***@***.***> wrote: Thanks @alex <https://github.com/alex> I'll try my best Sure, I hope you can help me on places where RevokedCertificate gets too complex :) — Reply to this email directly, view it on GitHub <#11437 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBDZXJEXQ5O44EDYTMDZ4F2JNAVCNFSM6AAAAABMTCYXKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGIZTMNRYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

[TreavVasu]

Thanks I was about to ask for this too.
U saved me here XD