Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Division Operation Outside of calc() in Sass Files #17

Open
swmcc opened this issue Aug 20, 2023 · 0 comments
Open

Deprecated Division Operation Outside of calc() in Sass Files #17

swmcc opened this issue Aug 20, 2023 · 0 comments
Labels
bug good first issue A good issue to get started with

Comments

@swmcc
Copy link
Member

swmcc commented Aug 20, 2023

I identified a bug in our Sass files where the division operation (/) is used outside of the calc() function. This usage is deprecated and will be removed in Dart Sass 2.0.0. As a result, the affected code may become incompatible with future versions of Dart Sass, leading to errors and unexpected behaviour.

Steps to reproduce:

Run the jekyll server - bundle exec jekyll serve
Open the relevant Sass files.
Search for instances where the division operation (/) is used outside of the calc() function.

Screenshot 2023-08-20 at 23 14 58

Expected behaviour:
Division operations should either be within the calc() function or replaced with the appropriate alternative.

Actual behaviour:
Division operations are used outside of the calc() function, which is deprecated.

Impact:
This issue may lead to errors and unexpected behavior when using Dart Sass 2.0.0 or later versions.

Suggested solution:
Update the Sass files to either move the division operations within the calc() function or replace them with the appropriate alternative, such as the math.div() function.

It is important to address this bug as soon as possible to ensure compatibility with future versions of Dart Sass and avoid potential errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue A good issue to get started with
Projects
None yet
Development

No branches or pull requests

1 participant