Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometric input params #4665

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Dec 11, 2024

Description

This pull request implements a SymbolicUniform1DSubmesh, which allows for geometric parameters, such as electrode thicknesses and particle sizes to be pybamm.InputParameter's.

Fixes #3649

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 55.30303% with 59 lines in your changes missing coverage. Please review.

Project coverage is 98.96%. Comparing base (72c23ea) to head (d468be4).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/spatial_methods/finite_volume.py 65.85% 28 Missing ⚠️
src/pybamm/meshes/one_dimensional_submeshes.py 15.00% 17 Missing ⚠️
src/pybamm/meshes/meshes.py 51.72% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4665      +/-   ##
===========================================
- Coverage    99.21%   98.96%   -0.26%     
===========================================
  Files          302      302              
  Lines        22858    22998     +140     
===========================================
+ Hits         22679    22760      +81     
- Misses         179      238      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Geometry parameters must be Scalars after parameter processing
2 participants