Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all-contributors bot so we can have required workflows #4671

Closed
kratman opened this issue Dec 12, 2024 · 2 comments · Fixed by #4675
Closed

Fix all-contributors bot so we can have required workflows #4671

kratman opened this issue Dec 12, 2024 · 2 comments · Fixed by #4675
Assignees
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours

Comments

@kratman
Copy link
Contributor

kratman commented Dec 12, 2024

The all-contributors bot uses the [skip ci] command. This prevents us from having required checks on github actions. I attempted a workaround, but had to revert the change since it did not work properly.

This is mainly a reminder for myself. I will fix this in a couple days

@kratman kratman added the CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) label Dec 12, 2024
@kratman kratman self-assigned this Dec 12, 2024
@agriyakhetarpal
Copy link
Member

To fix: set skipCi to false in the all-contributors bot's settings and use paths: / paths-ignore: accordingly to ignore the all-contributors.md file for all workflows.

xref: #3662

@agriyakhetarpal agriyakhetarpal added the difficulty: easy A good issue for someone new. Can be done in a few hours label Dec 13, 2024
@kratman
Copy link
Contributor Author

kratman commented Dec 13, 2024

Thanks. I was trying GitHub side options yesterday, but ran out of time. I figured this was possible, I will try it this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to continuous integration, continuous deployment (GitHub Actions, workflows, testing, etc.) difficulty: easy A good issue for someone new. Can be done in a few hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants