Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default SPMe and DFN models/examples have no NE potential or overpotential #3566

Closed
tommaull opened this issue Nov 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@tommaull
Copy link
Contributor

PyBaMM Version

lastest Dev and Main as of 27/11/23

Python Version

3.9

Describe the bug

image

NE response is implausible - hovering around 0 potential, with no overpotential behaviours.

Steps to Reproduce

Run 23.9 Main, SPMe example. Observe NE behaviour.

Relevant log output

No response

@tommaull tommaull added the bug Something isn't working label Nov 27, 2023
@rtimms
Copy link
Contributor

rtimms commented Nov 27, 2023

This is because we measure potential wrt the solid phase negative electrode potential at x=0, whereas I'm guessing what you're expecting is the potential measured wrt to a different reference, such as the electrolyte potential?

@rtimms
Copy link
Contributor

rtimms commented Nov 27, 2023

See also #3470 and #3254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants