-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate a better way to repair wheels for Linux and macOS #3558
Labels
Comments
agriyakhetarpal
added
difficulty: medium
Will take a few days
priority: medium
To be resolved if time allows
labels
Nov 25, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
Fails in CI on Windows but the wheel does contain a .pyd file, so it passes on Windows locally. Another reason is that `casadi` cannot be imported on manylinux2014 containers at this moment
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Nov 27, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 1, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 1, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 1, 2023
…for alternative `casadi` installations Co-Authored-By: jsbrittain <[email protected]>
6 tasks
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
CMake showed a warning about these arguments not being used during the compilation of the project.
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
agriyakhetarpal
added a commit
to agriyakhetarpal/PyBaMM
that referenced
this issue
Dec 14, 2023
SuiteSparse dynamic libraries were being repeated in the list of paths without this configuration. Setting build rpaths for AMD, COLAMD, BTF, and KLU ensures that they do not reference the SuiteSparse config in the build folder but the one that is installed into the install prefix.
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
…for alternative `casadi` installations Co-Authored-By: jsbrittain <[email protected]>
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
CMake showed a warning about these arguments not being used during the compilation of the project.
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
SuiteSparse dynamic libraries were being repeated in the list of paths without this configuration. Setting build rpaths for AMD, COLAMD, BTF, and KLU ensures that they do not reference the SuiteSparse config in the build folder but the one that is installed into the install prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The addition of
pyproject.toml
in #3301 presented a hacky way to find the CasADi dynamic libraries or shared object files at the time of repairing the wheel, but the ideal method would be to adjust the runtime search path for theidaklu
target and build the wheel using a different frontend instead ofpip
, i.e., usingpython -m build
. This would make repairing the wheel easier since the target can look at the right path to find the libraries, wherebycasadi
can be pre-installed to counter PEP517/518 build isolation at the time of building wheels.The text was updated successfully, but these errors were encountered: