Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]: Lower version bounds of anytree and imageio? - conda and pip conflict #3544

Closed
Saransh-cpp opened this issue Nov 21, 2023 · 1 comment · Fixed by #3570
Closed
Labels
dependencies Pull requests that update a dependency file difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@Saransh-cpp
Copy link
Member

2 of our dependencies have different latest versions on conda and pip, which created a minor issue in the conda release. Lowering the version bounds for these dependencies to a common value worked.


The workflows failed when I update the versions to match our PyPI requirements in conda-forge/pybamm-feedstock@cedf7b6, so it looks like the workflows are not installing the dependencies from pip -

The following packages are incompatible
├─ anytree >=2.12.0  does not exist (perhaps a typo or a missing channel);
└─ imageio >=2.32.0  does not exist (perhaps a typo or a missing channel).

Originally posted by @Saransh-cpp in conda-forge/pybamm-feedstock#54 (comment)

I think we should lower the bounds for these dependencies in the next PyPI release as well - to maintain uniformity between the conda and PyPI packages - but I'm not very sure of this.

Originally posted by @Saransh-cpp in conda-forge/pybamm-feedstock#54 (comment)

@Saransh-cpp Saransh-cpp added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows dependencies Pull requests that update a dependency file labels Nov 21, 2023
@agriyakhetarpal
Copy link
Member

I read up a bit on this and imo lowering the version bounds should be a good idea, especially for packages that are not as big or as frequently maintained compared to those in the Scientific Python ecosystem. Packages that are outside of the ecosystem and subsequently those with lesser adoption or usage rates generally do not feel the need to bring conda-forge releases at the same time as their PyPI release counterparts, which brings us to this version mismatch. Out of our core dependencies: numpy and scipy work in tandem, xarray is quick at releases, but casadi and anytree tend to be on the slower side; their versions should be kept in sync from PyBaMM 24.1 onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants