-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make release v23.9 #3538
Make release v23.9 #3538
Conversation
Co-authored-by: Saransh Chopra <[email protected]>
This reverts commit cf1b276.
This reverts commit 2ec97c1.
Clean up installation guides
Dockerize PyBaMM
Split CI test groups into concurrent jobs
Invoke custom `build.jobs` for PDF builds on Read the Docs
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Bug fix: Improve cracking integration tests and examples on M-series hardware
…-support Drop support for i686 manylinux
Improve release workflow, add a note, bump version manually
Build wheels on the 1st and 15th of every month
#3428 exchange-current density error
Fix failing windows wheel builds
make initial soc work with half cell models
JaxSolver fails when using GPU support with no input parameters
Resolve default imports for optional dependencies
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Are the mac failing tests new?
Yes, looks like a new error. I will try rerunning them once the other tests are executed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
- Coverage 99.71% 99.58% -0.13%
==========================================
Files 248 256 +8
Lines 18900 20106 +1206
==========================================
+ Hits 18846 20023 +1177
- Misses 54 83 +29 ☔ View full report in Codecov by Sentry. |
Looks like this has been fixed in develop, but not in v23.9. The scheduled macos tests are passing on this PR so it should be fine to merge this. Leaving this open for reviews. Will merge this in an hour! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, @Saransh-cpp! The macOS tests are failing because of the brew update
command, which has been fixed in the develop
branch as you mentioned.
Description
I will create a release once this is merged into main.
Fixes #3374
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: