-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom experiment steps #3530
Comments
Adding custom events should be really easy and could be done first separately, we just need to implement a Lines 279 to 284 in 7c15368
We could allow the |
For the custom steps, there will be two separate cases:
Current and C-rate falls into 1, everything else falls into 2. We will need two different |
The logic for specifying how experiment steps work is currently in the
Simulation
class. We should move this to theStep
classes, so that users can specify any custom behavior they want for which variable controls the step, and which variable(s) are used in the termination. This will have the added benefit of reducing some of the complexity of the simulation class.This involves replacing any if statement that checks
op.type
with a call to a function in the step class, e.g. https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/simulation.py#L222The text was updated successfully, but these errors were encountered: