#3506 vectorize theoretical energy

[valentinsulzer]

Description

Fixes #3506

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2324af9) 99.58% compared to head (72579c6) 99.58%.
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3510   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        20054    20058    +4     
========================================
+ Hits         19971    19975    +4     
  Misses          83       83           

Files	Coverage Δ
pybamm/expression_tree/binary_operators.py	100.00% <100.00%> (ø)
pybamm/expression_tree/broadcasts.py	100.00% <100.00%> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py	98.87% <100.00%> (-0.01%)	⬇️
pybamm/parameters/lithium_ion_parameters.py	100.00% <100.00%> (ø)
pybamm/parameters/thermal_parameters.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brosaplanella]

Looks good, thanks! Do you have a screenshot of the time profiler after the changes?

[valentinsulzer]