Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify installation by indicating pybind11 as a build-time dependency #3480

Closed
agriyakhetarpal opened this issue Oct 27, 2023 · 1 comment
Closed

Simplify installation by indicating pybind11 as a build-time dependency #3480

agriyakhetarpal opened this issue Oct 27, 2023 · 1 comment
Assignees
@agriyakhetarpal
Labels
difficulty: medium Will take a few days priority: medium To be resolved if time allows

Comments

@agriyakhetarpal
Copy link
Member

We currently git-clone the pybind11 repository inside the pybamm-requires nox session when installing from source. Once #3301 is merged, this step can be removed by either including it as a submodule in the repository, or via adding it to the [build-system] section in pyproject.toml plus suitable modifications to the CMake build process. The latter option would be better
@agriyakhetarpal agriyakhetarpal added difficulty: medium Will take a few days priority: medium To be resolved if time allows labels Oct 27, 2023
@agriyakhetarpal agriyakhetarpal mentioned this issue Nov 25, 2023
Merged
8 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 Specify pybind11 as a build-time dependency
9855e9d
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 Modify logic that finds pybind11 CMake files
60da4cb
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 use find_package() to find pybind11
cc67bba
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 Don't git-clone pybind11 now
0cb4fb6
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 remove pybind11 references from gitignore
5b4f9af
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 remove pybind11 from caches
81eb5f8
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 remove pybind11 clone step from wheel builds
d256206
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 remove pybind11 git-clone from Docker images
354585f
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 remove pybind11 git-clone instructions for source …
e462292 
…installation
@agriyakhetarpal agriyakhetarpal mentioned this issue Nov 25, 2023
Closed
8 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 add a CHANGELOG entry
f20f035
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 use an alternative way for CMake to detect pybind11
5887feb
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 Surefire way for KLU compilation on various platforms
59f25e5
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Nov 25, 2023
@agriyakhetarpal
pybamm-team#3480 pybind11 is to be installed for benchmarks
daeb726
@agriyakhetarpal agriyakhetarpal moved this to In Progress in November 2023 sprint Nov 27, 2023
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 update build command for asv benchmarks
7c717f9
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 retry setup.py build command for asv
f10b3a4
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 retry asv build command without cache dir
5d902bc
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Try asv singular build command instead of two
9f2d3db
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 reset benchmarks and update build command
9277940
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 update pybind11 for workflow + revert to 3.8
cc33154
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 use default built-in asv build command
891eab8
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 skip specific missing workflows on forks
87d7e40
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Install CMake alongside nox
36c7613
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Install CMake alongside nox and skip `pybamm-req…
2da613d 
…uires`
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Remove CMake as a build-time dependency
91e40f3
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Add notes about how to install CMake
4831708
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Modify logic that checks for CMake + pybind11
9118c2b
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
Revert "pybamm-team#3480 Install CMake alongside nox and skip `py…
44ce67e 
…bamm-requires`"

This reverts commit 2da613d.
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Dec 16, 2023
@agriyakhetarpal
pybamm-team#3480 Install nox and CMake wherever needed
e80aaef
@agriyakhetarpal agriyakhetarpal mentioned this issue Dec 21, 2023
Closed
5 tasks
@agriyakhetarpal
Copy link
Member Author

Closing, this is now being tracked in one place as a part of the migration to `scikit-build-core by @cringeyburger in #3564

@agriyakhetarpal agriyakhetarpal closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in November 2023 sprint May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agriyakhetarpal agriyakhetarpal

Labels
difficulty: medium Will take a few days priority: medium To be resolved if time allows
Projects
December 2023 - January 2024 sprint
Status: Done
November 2023 sprint
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify pybind11 as a build-time dependency agriyakhetarpal/PyBaMM
1 participant
@agriyakhetarpal