Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the URL checker #3386

Closed
Saransh-cpp opened this issue Oct 1, 2023 · 6 comments · Fixed by #3393
Closed

Fix the URL checker #3386

Saransh-cpp opened this issue Oct 1, 2023 · 6 comments · Fixed by #3393
Assignees
@Agnik7
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours hacktoberfest priority: low No existing plans to resolve

Comments

@Saransh-cpp
Copy link
Member

lychee is failing here at the moment -

PyBaMM/CONTRIBUTING.md

Line 188 in 7eb5879

You may also use an appropriate [glob pattern](https://www.malikbrowne.com/blog/a-beginners-guide-glob-patterns) to run all notebooks matching a particular folder or name pattern.

We could use a different material to reference glob pattern?
@Saransh-cpp Saransh-cpp added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve hacktoberfest labels Oct 1, 2023
@Agnik7
Copy link
Contributor

Agnik7 commented Oct 1, 2023

Hi @Saransh-cpp I am participating in Hacktoberfest and would love to work on this issue!! Kindly assign this to me.

@Saransh-cpp
Copy link
Member Author

Hi, go ahead!

@Agnik7
Copy link
Contributor

Agnik7 commented Oct 2, 2023

@Saransh-cpp I have one query. I need to work and then send the PR to the develop branch right?

@Saransh-cpp
Copy link
Member Author

Yes. You can also refer to the Contributing Guide for detailed steps.

@Agnik7
Copy link
Contributor

Agnik7 commented Oct 2, 2023

Ok thanks

@Agnik7 Agnik7 mentioned this issue Oct 2, 2023
Merged
8 tasks
@Agnik7
Copy link
Contributor

Agnik7 commented Oct 2, 2023

@Saransh-cpp I have created a PR #3393 . Requesting for your review. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Agnik7 Agnik7

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours hacktoberfest priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix URL Checker Agnik7/PyBaMM
2 participants
@Saransh-cpp @Agnik7