-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated pkg_resources #3335
Replace deprecated pkg_resources #3335
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3335 +/- ##
===========================================
- Coverage 99.57% 99.56% -0.02%
===========================================
Files 253 253
Lines 19571 19559 -12
===========================================
- Hits 19488 19474 -14
- Misses 83 85 +2
☔ View full report in Codecov by Sentry. |
The drop in coverage appears to be from the code in #3116, not the changes from this PR |
f6641c9
to
07f7068
Compare
@agriyakhetarpal I did not see the changes there when I went to do this. This one is small and ready to go though. I rebased yesterday to see if it would retrigger the coverage report which was showing a drop due to a different merged PR. It passed everything else before I did the rebase. |
Yes, that PR is a bit stalled though, for other reasons. The changes there are similar to yours and everything passes, I expect them to pass here too |
The failing tests ( |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! @Saransh-cpp, could you trigger a workflow run here?
@Saransh-cpp, @agriyakhetarpal It looks like coverage is dropping due to the version logic. Is there something else you want me to change, or is this OK? |
Perhaps adding |
Yes, should be fine in this case. |
Changed thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kratman!
Description
While looking through the code, I noticed a deprecation warning for pkg_resources. I replaced the two usages I found in the code with importlib.metadata.
Type of change
Only changes an imported library, there should be no real changes to the functionality.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: