Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin asv version to fix failing benchmarks #3307

Closed
brosaplanella opened this issue Sep 4, 2023 · 1 comment · Fixed by #3310
Closed

Pin asv version to fix failing benchmarks #3307

brosaplanella opened this issue Sep 4, 2023 · 1 comment · Fixed by #3310
Assignees
@arjxn-py
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours in-progress Assigned in the core dev monthly meeting priority: high To be resolved as soon as possible

Comments

@brosaplanella
Copy link
Member

No description provided.

@agriyakhetarpal
Copy link
Member

Related: airspeed-velocity/asv#1323. We could pin asv==0.5.1 and/or wait for airspeed-velocity/asv#1324

@brosaplanella brosaplanella added difficulty: easy A good issue for someone new. Can be done in a few hours priority: high To be resolved as soon as possible labels Sep 4, 2023
@brosaplanella brosaplanella moved this to In Progress in September 2023 sprint Sep 4, 2023
@brosaplanella brosaplanella added the in-progress Assigned in the core dev monthly meeting label Sep 4, 2023
@arjxn-py arjxn-py mentioned this issue Sep 5, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in September 2023 sprint Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjxn-py arjxn-py

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours in-progress Assigned in the core dev monthly meeting priority: high To be resolved as soon as possible
Projects
No open projects
September 2023 sprint
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin asv==0.5.1 to fix failing benchmarks arjxn-py/PyBaMM
3 participants
@brosaplanella @agriyakhetarpal @arjxn-py