Skip to content

Commit

Permalink
Fixed a bug where the SEI thickness decreased at some intervals when …
Browse files Browse the repository at this point in the history
…using the 'electron-migration limited' model. (#3622)

* The 'electron-migration limited' model has been corrected by considering only negative contributions to eta_sei in the j_sei

* Update pybamm/models/submodels/interface/sei/sei_growth.py

Co-authored-by: Eric G. Kratz <[email protected]>

* Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside for more clarity

---------

Co-authored-by: Eric G. Kratz <[email protected]>
  • Loading branch information
kawaMANMI and kratman authored Jan 18, 2024
1 parent 73b470f commit 20049db
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pybamm/models/submodels/interface/sei/sei_growth.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ def get_coupled_variables(self, variables):
elif SEI_option == "electron-migration limited":
# Scott Marquis thesis (eq. 5.94)
eta_inner = delta_phi - phase_param.U_inner
j_sei = phase_param.kappa_inner * eta_inner / L_sei_inner

j_sei = (eta_inner < 0) * phase_param.kappa_inner * eta_inner / L_sei_inner
elif SEI_option == "interstitial-diffusion limited":
# Scott Marquis thesis (eq. 5.96)
j_sei = -(
Expand Down

0 comments on commit 20049db

Please sign in to comment.