Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection speed #431

Open
eslam2010011 opened this issue Apr 19, 2020 · 5 comments
Open

connection speed #431

eslam2010011 opened this issue Apr 19, 2020 · 5 comments
Labels

Comments

@eslam2010011
Copy link

this library be from Facebook, can it be combined with your library to measure internet speed? Thank you

https://github.com/facebookarchive/network-connection-class

@pwittchen
Copy link
Owner

It can be combined with any library. It's developer choice how to perform an integration. In the case of the linked library, everything depends on what you want to achieve.

@eslam2010011
Copy link
Author

Can you add it now, thank you

@pwittchen
Copy link
Owner

I don't want to add too many dependencies to this library. If you want to combine network-connection-class and ReactiveNetwork, then it should be done in your application. Moreover, I don't know what do you want to achieve, so even if I'd like to add new functionality to my library, I don't know your expectations.

@eslam2010011
Copy link
Author

This helps a lot in making decisions, such as whether the internet is weak, it switches to offline mode, and when the internet is strong, it switches to online mode, not just knowledge, there is internet or not

@pwittchen
Copy link
Owner

I know, but this library has single responsibility. I don't want to put too many things in it. You can combine these two projects in your app by yourself if you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants