Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Times parameter description for solar position algorithms #2230

Open
AdamRJensen opened this issue Sep 28, 2024 · 0 comments
Open

Times parameter description for solar position algorithms #2230

AdamRJensen opened this issue Sep 28, 2024 · 0 comments

Comments

@AdamRJensen
Copy link
Member

AdamRJensen commented Sep 28, 2024

pvlib currently uses variants of the following description for the times parameter in the solar position algorithms:

times : pandas.DatetimeIndex
    Must be localized or UTC will be assumed.

However, times should actually be UT1!

UTC has been maintained within ±0.9 of UT1 since 1970 ish by adding leap seconds. However, prior to 1970s there are large deviations between UTC and UT1, and there may be in the future too. Therefore, I think it's wise to update the times parameter to something along the lines of:

times : pandas.DatetimeIndex
    Must be localized or UTC/UT1 will be assumed. Prior to 1970 and far in
    the future UTC and UT1 may deviate significantly and in such cases
    UT1 times should be provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants