Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Add instrumenting lab #42

Merged
merged 6 commits into from
Nov 27, 2020
Merged

Add instrumenting lab #42

merged 6 commits into from
Nov 27, 2020

Conversation

rotscher
Copy link
Contributor

No description provided.

@rotscher rotscher self-assigned this Nov 26, 2020
@rotscher rotscher changed the title WIP: Add initial ideas about instrumenting lab WIP: Add instrumenting lab Nov 26, 2020
@rotscher rotscher changed the title WIP: Add instrumenting lab Add instrumenting lab Nov 27, 2020
Copy link
Contributor

@mebagel mebagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Client libraries

The Prometheus project provides [client libraries](https://prometheus.io/docs/instrumenting/clientlibs/) which are either official or maintained by third-parties. There are libraries for the major languages like Java, Golang, Python, PHP and even .net/C#.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Prometheus project provides [client libraries](https://prometheus.io/docs/instrumenting/clientlibs/) which are either official or maintained by third-parties. There are libraries for the major languages like Java, Golang, Python, PHP and even .net/C#.
The Prometheus project provides [client libraries](https://prometheus.io/docs/instrumenting/clientlibs/) which are either official or maintained by third-parties. There are libraries for major languages like Java, Golang, Python, PHP and even .net/C#.


{{% details title="Task 2" %}}

No, it's not the possible security vulnerability (which seems to be handled appropriate in this case, by the way).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
No, it's not the possible security vulnerability (which seems to be handled appropriate in this case, by the way).
No, it's not the possible security vulnerability (which seems to be handled by the way appropriate in this case).

@rotscher rotscher linked an issue Nov 27, 2020 that may be closed by this pull request
@rotscher rotscher merged commit 636d6e2 into main Nov 27, 2020
@niwo niwo deleted the feature/add-instrumenting-lab branch December 4, 2020 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentalisierung, Client Libraries
2 participants