From bfb942e3186f09a416257c097352be701a06861c Mon Sep 17 00:00:00 2001 From: Harry Garrood Date: Tue, 28 May 2019 13:32:09 +0100 Subject: [PATCH] Drop typelevel-prelude dependency We aren't actually using anything provided by typelevel-prelude; instead, we're only using its re-exports. Dropping the dependency and importing RLProxy and the Union class from where they are defined means that we have fewer dependencies to worry about, so version incompatibilities are less likely to occur. I'd suggest releasing this as a patch-level change; previously we have recommended releasing changes in which dependencies have been dropped as major-level, because it can break downstream libraries if they are relying on the presence of that dependency, but I have come to believe that this policy is worse since it results in far too many unnecessary major version bumps, and downstream libraries depending on a particular transitive dependency but not declaring that dependency are arguably broken anyway. --- bower.json | 1 - src/React/Basic.purs | 2 +- src/React/Basic/Events.purs | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bower.json b/bower.json index 767d871..d7c9d6e 100644 --- a/bower.json +++ b/bower.json @@ -14,7 +14,6 @@ "purescript-functions": "^4.0.0", "purescript-nullable": "^4.1.0", "purescript-record": "^1.0.0", - "purescript-typelevel-prelude": "^3.0.0", "purescript-unsafe-coerce": "^4.0.0", "purescript-web-dom": "^1.0.0", "purescript-web-html": "^1.0.0", diff --git a/src/React/Basic.purs b/src/React/Basic.purs index 4804238..9d2cb48 100644 --- a/src/React/Basic.purs +++ b/src/React/Basic.purs @@ -28,7 +28,7 @@ import Data.Function.Uncurried (Fn2, mkFn2, runFn2) import Data.Nullable (Nullable, notNull, null) import Effect (Effect) import Effect.Uncurried (EffectFn3, runEffectFn3) -import Type.Row (class Union) +import Prim.Row (class Union) -- | `ComponentSpec` represents a React-Basic component implementation. -- | diff --git a/src/React/Basic/Events.purs b/src/React/Basic/Events.purs index 46931be..199fc1a 100644 --- a/src/React/Basic/Events.purs +++ b/src/React/Basic/Events.purs @@ -19,7 +19,7 @@ import Effect.Uncurried (EffectFn1, mkEffectFn1) import Prim.Row as Row import Prim.RowList (kind RowList, class RowToList, Cons, Nil) import Record (delete, get, insert) -import Type.Row (RLProxy(..)) +import Type.Data.RowList (RLProxy(..)) -- | An event handler, which receives a `SyntheticEvent` and performs some -- | effects in return.