Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We probably shouldn't use the "JSS" top level module name #88

Open
hdgarrood opened this issue Aug 14, 2019 · 1 comment
Open

We probably shouldn't use the "JSS" top level module name #88

hdgarrood opened this issue Aug 14, 2019 · 1 comment

Comments

@hdgarrood
Copy link
Contributor

... in a library which isn't called purescript-jss. Can we move it to Lumi.Components.JSS or something instead? It's necessarily a breaking change, which is a bit inconvenient, but I think there's a good chance this will collide with another library at some point if we leave it.
@megamaddu
Copy link
Member

Good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@megamaddu @hdgarrood