Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove String props where possible #3

Open
paf31 opened this issue Apr 16, 2019 · 0 comments
Open

Remove String props where possible #3

paf31 opened this issue Apr 16, 2019 · 0 comments
Labels
planned API change Things we intend to break soon

Comments

@paf31
Copy link

paf31 commented Apr 16, 2019

  • props like variant should be full enums or removed and the component split into separate more specialized components
  • content, child, text, etc, props are generally better as JSX than strings because it's just about as opaque while being flexible enough to allow interesting component composition
@paf31 paf31 added the planned API change Things we intend to break soon label Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
planned API change Things we intend to break soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paf31