Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v8.0.0 #390

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Release prep v8.0.0 #390

merged 1 commit into from
Apr 30, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 15, 2024

Automated release-prep through pdk-templates from commit 5656cdb.
Please verify before merging:

@github-actions github-actions bot requested review from bastelfreak, smortex and a team as code owners February 15, 2024 18:30
@h0tw1r3 h0tw1r3 marked this pull request as draft February 15, 2024 18:38
@h0tw1r3
Copy link
Contributor

h0tw1r3 commented Feb 15, 2024

@bastelfreak @smortex I'm going back and forth on if a major version bump should be done, because of the firewall module bump and platform support drops.
And if it is a major release, should the postgresql module bump be included also?

@bastelfreak
Copy link
Collaborator

100% this is a major release and should be 8.0.0. And we should include #379

@@ -1,656 +1,580 @@
## puppetlabs-puppetdb changelog
<!-- markdownlint-disable MD024 -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to rewrite the whole changelog? I think this project uses not the github changelog generator? That allows to put the old changelog in a HISTORY.md and keep it. Makes the diff way more readable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-opening, see #399

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap, the changelog is not generated with the rake changelog task 😒.

I recall triaging all issues in various modules, so I guess we want to do this too for consistency? The current tooling will then generate a full changelog without HISTORY.md on each release, but as the HISTORY.md contain the old changelog, maybe it will not be too bad?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I labelled issues, and regenerated CHANGELOG.md by hand (because it is not currently in the main branch so the GitHub action does not think it must be updated). This is a PITA only for this release as the next ones will not have this corner case.

@h0tw1r3 h0tw1r3 changed the title Release prep v7.20.0 Release prep v8.0.0 Feb 15, 2024
@puppetlabs puppetlabs deleted a comment from jonathannewman Feb 19, 2024
@zilchms
Copy link

zilchms commented Mar 20, 2024

Should there be a release after #395 is merged or are there still things that should be waited on?

@bastelfreak
Copy link
Collaborator

I wanted to regenerate the CHANGELOG.md, but this fails: https://github.com/puppetlabs/puppetlabs-puppetdb/actions/runs/8642538232/job/23693810562

@smortex
Copy link
Collaborator

smortex commented Apr 15, 2024

I wanted to regenerate the CHANGELOG.md, but this fails: puppetlabs/puppetlabs-puppetdb/actions/runs/8642538232/job/23693810562

Looks like there was some issues in the pdk templates that got fixed.

@smortex
Copy link
Collaborator

smortex commented Apr 19, 2024

I guess we want to merge this one: #357

@bastelfreak bastelfreak marked this pull request as ready for review April 30, 2024 13:28
@bastelfreak bastelfreak merged commit aebcbea into main Apr 30, 2024
24 checks passed
@bastelfreak bastelfreak deleted the release-prep branch April 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants