A lot of warnings and errors on the puppet-lint output

[fsalum]

Puppet-lint is failing with a lot of errors and warnings.

$ puppet-lint --with-filename --no-80chars-check modules/puppetdbmodules/puppetdb
/manifests/database/postgresql.pp - WARNING: class inheriting from params class on line 47
modules/puppetdb/manifests/database/postgresql_db.pp - WARNING: class inheriting from params class on line 32
modules/puppetdb/manifests/init.pp - WARNING: class inheriting from params class on line 114
modules/puppetdb/manifests/init.pp - WARNING: selector inside resource block on line 176
modules/puppetdb/manifests/init.pp - WARNING: indentation of => is not properly aligned on line 171
modules/puppetdb/manifests/master/config.pp - WARNING: class inheriting from params class on line 78
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 88
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 89
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 106
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 116
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 127
modules/puppetdb/manifests/master/config.pp - WARNING: selector inside resource block on line 138
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 85
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 86
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 87
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 88
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 89
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 90
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 91
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 92
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 94
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 95
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 96
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 97
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 98
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 132
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 133
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 134
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 135
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 136
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 137
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 138
modules/puppetdb/manifests/master/config.pp - ERROR: tab character found on line 139
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 85
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 86
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 87
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 88
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 89
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 90
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 91
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 92
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 94
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 95
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 96
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 97
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 98
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 132
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 133
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 134
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 135
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 136
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 137
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 138
modules/puppetdb/manifests/master/config.pp - ERROR: two-space soft tabs not used on line 139
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 88
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 89
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 106
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 116
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 127
modules/puppetdb/manifests/master/config.pp - WARNING: indentation of => is not properly aligned on line 138
modules/puppetdb/manifests/master/puppetdb_conf.pp - WARNING: class inheriting from params class on line 29
modules/puppetdb/manifests/master/report_processor.pp - WARNING: class inheriting from params class on line 25
modules/puppetdb/manifests/master/report_processor.pp - WARNING: selector inside resource block on line 33
modules/puppetdb/manifests/master/report_processor.pp - WARNING: double quoted string containing no variables on line 27
modules/puppetdb/manifests/master/report_processor.pp - WARNING: indentation of => is not properly aligned on line 31
modules/puppetdb/manifests/master/report_processor.pp - WARNING: indentation of => is not properly aligned on line 32
modules/puppetdb/manifests/master/report_processor.pp - WARNING: indentation of => is not properly aligned on line 33
modules/puppetdb/manifests/master/report_processor.pp - WARNING: ensure found on line but it's not the first attribute on line 33
modules/puppetdb/manifests/master/routes.pp - WARNING: class inheriting from params class on line 24
modules/puppetdb/manifests/master/storeconfigs.pp - WARNING: class inheriting from params class on line 23
modules/puppetdb/manifests/params.pp - ERROR: trailing whitespace found on line 81
modules/puppetdb/manifests/params.pp - ERROR: trailing whitespace found on line 92
modules/puppetdb/manifests/params.pp - ERROR: trailing whitespace found on line 101
modules/puppetdb/manifests/server/database_ini.pp - WARNING: class inheriting from params class on line 51
modules/puppetdb/manifests/server/firewall.pp - WARNING: class inheriting from params class on line 8
modules/puppetdb/manifests/server/firewall.pp - WARNING: class not documented on line 1
modules/puppetdb/manifests/server/firewall.pp - ERROR: trailing whitespace found on line 3
modules/puppetdb/manifests/server/firewall.pp - ERROR: trailing whitespace found on line 30
modules/puppetdb/manifests/server/firewall.pp - ERROR: trailing whitespace found on line 38
modules/puppetdb/manifests/server/jetty_ini.pp - WARNING: class inheriting from params class on line 41
modules/puppetdb/manifests/server/jetty_ini.pp - ERROR: trailing whitespace found on line 36
modules/puppetdb/manifests/server/validate_db.pp - WARNING: class inheriting from params class on line 52
modules/puppetdb/manifests/server.pp - WARNING: class inheriting from params class on line 123
modules/puppetdb/manifests/server.pp - ERROR: trailing whitespace found on line 193
modules/puppetdb/tests/puppetdb-postgres-distributed.pp - ERROR: trailing whitespace found on line 14
modules/puppetdb/tests/puppetdb-postgres-distributed.pp - ERROR: trailing whitespace found on line 26
modules/puppetdb/tests/puppetdb-postgres-distributed.pp - ERROR: trailing whitespace found on line 2

[h0tw1r3]

Fixed in #385