Skip to content

Commit

Permalink
Merge pull request #404 from rwaffen/add_version_fact
Browse files Browse the repository at this point in the history
Add a `puppetdb_version` fact with PuppetDB version
  • Loading branch information
smortex authored May 3, 2024
2 parents 99cbeea + d2db654 commit 3afd693
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 0 deletions.
8 changes: 8 additions & 0 deletions lib/facter/puppetdb_version.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Facter.add(:puppetdb_version) do
confine { Facter::Util::Resolution.which('puppetdb') }

setcode do
output = Facter::Core::Execution.execute('puppetdb --version')
output.split(':').last.strip
end
end
25 changes: 25 additions & 0 deletions spec/unit/facter/puppetdb_version_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# frozen_string_literal: true

require 'spec_helper'
require 'facter'

describe 'puppetdb_version' do
subject(:fact) { Facter.fact(:puppetdb_version) }

before(:each) do
Facter.clear
end

it 'returns the correct puppetdb version' do
allow(Facter::Util::Resolution).to receive(:which).with('puppetdb').and_return('/usr/bin/puppetdb')
allow(Facter::Core::Execution).to receive(:execute).with('puppetdb --version').and_return("puppetdb version: 7.18.0\n")

expect(Facter.fact(:puppetdb_version).value).to eq('7.18.0')
end

it 'returns nil if puppetdb command is not available' do
allow(Facter::Util::Resolution).to receive(:which).with('puppetdb').and_return(nil)

expect(Facter.fact(:puppetdb_version).value).to be_nil
end
end

0 comments on commit 3afd693

Please sign in to comment.