From dacd953266f62ef7eeba1fa5ae78f85269837f64 Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Wed, 9 Oct 2024 08:51:18 +0100 Subject: [PATCH 1/3] (CAT-2013) Adjust shellcheck call Shellcheck has been moved to our reusable workflows repository and is now part os our CI testing. As such, we are removing the action from here and enabling it to be called. --- .github/workflows/ci.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8f8f121..fa9ff3f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,15 +7,9 @@ on: workflow_dispatch: jobs: - shellcheck: - name: Shellcheck - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: reviewdog/action-shellcheck@v1 - with: - check_all_files_with_shebangs: "true" - Spec: uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main" + with: + # This line enables shellcheck to be run on this repository + run_shellcheck: true secrets: "inherit" From 71acc3fca25514dee6ed9a15fa2b11d37e518fda Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Mon, 14 Oct 2024 16:30:57 +0100 Subject: [PATCH 2/3] test on implemented branch --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fa9ff3f..f8ead66 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ on: jobs: Spec: - uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main" + uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@CAT-2094-shellcheck_in_module_ci" with: # This line enables shellcheck to be run on this repository run_shellcheck: true From bff80cfb61fc4959bd818af67bbac332411685c0 Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Tue, 15 Oct 2024 13:32:50 +0100 Subject: [PATCH 3/3] undo test changes --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f8ead66..fa9ff3f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ on: jobs: Spec: - uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@CAT-2094-shellcheck_in_module_ci" + uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main" with: # This line enables shellcheck to be run on this repository run_shellcheck: true