Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PF provider_server detailed diff handling #2628

Merged
merged 4 commits into from
Nov 25, 2024

address review

12bb0f7
Select commit
Loading
Failed to load commit list.
Merged

Fix PF provider_server detailed diff handling #2628

address review
12bb0f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

69.39% (+0.03%) compared to bc33162

View this Pull Request on Codecov

69.39% (+0.03%) compared to bc33162

Details

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (bc33162) to head (12bb0f7).

Files with missing lines Patch % Lines
pkg/pf/internal/plugin/provider_server.go 61.76% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
+ Coverage   69.35%   69.39%   +0.03%     
==========================================
  Files         301      301              
  Lines       38558    38560       +2     
==========================================
+ Hits        26743    26759      +16     
+ Misses      10295    10281      -14     
  Partials     1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: