Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF previews do not display changes to secret values #2651

Closed
VenelinMartinov opened this issue Nov 21, 2024 · 0 comments · Fixed by #2643
Closed

PF previews do not display changes to secret values #2651

VenelinMartinov opened this issue Nov 21, 2024 · 0 comments · Fixed by #2643
Assignees
@VenelinMartinov
Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

When previewing changes where the only change is to a secret value, we do not mark the change against the value, yielding a confusing diff:

  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
    ~ testprovider:index/test:Test: (update)
        [id=test-id]
        [urn=urn:pulumi:test::test::testprovider:index/test:Test::mainRes]
        s: [secret]
Resources:
    ~ 1 to update
    1 unchanged

Here the change was to the s property.

See TestSecretBasic
@VenelinMartinov VenelinMartinov added area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec labels Nov 21, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Nov 21, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detailed diff handle secrets and outputs pulumi/pulumi-terraform-bridge
2 participants
@VenelinMartinov @pulumi-bot