Move integration tests to ./tests
#1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
commented
Nov 14, 2024
Comment on lines
-170
to
-172
| test_build:: | ||
| cd examples/utils/testvpc && yarn install && yarn run tsc | ||
|
|
There was a problem hiding this comment.
This directory doesn't exist.
blampe
changed the title
./tests./tests
flostadler
approved these changes
Nov 14, 2024
|
This PR has been shipped in release v3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates integration tests (currently located in
./examplesand./provider) under./tests.This is prep work for #1474, and the net result is a clearer distinction between "fast" and "slow" tests meant to be run during the "prerequisites" and "tests" steps in CI. Everything under
./providercan be considered "fast" and everything under./testscan be considered "slow" and worthy of sharding.Specifically:
./examples/testsis moved to./tests/testdata/programsas these were assumed to not be user-facing../providerare also moved to./testsbut tagged in a way that they continue to run as their own job. (These are the newupgrade_test.goandvalidation_test.gofiles.)examples/utils/utils.gomoves totests/internal/utils.TestEksAuthModeUpgradewasn't re-enabled as part of Re-Enable Upgrade tests #1387, so I re-enabled and re-recorded it.go.modis consolidated at the repo root to keep dependencies consistent across the provider and tests. (There are a ton of additional DX advantages to structuring things this way.) This project is not meant to be consumed as a library so this is an acceptable breaking change.