Fix ManagedNodeGroup with custom launch template and AMI type #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an EKS managed NodeGroup with a custom launch template, the AMI type must be removed from the nodegroup itself and instead specified in the launch template. This did not work if the user specified the AMI type instead of the provider determining it. This change fixes that by correctly omitting the user defined AMI type as well in that case.
Does the PR have any schema changes?Looking good! No breaking changes found. |
t0yv0
reviewed
Oct 28, 2024
| ...scalingConfig, | ||
| cluster: cluster, | ||
| nodeRole: role, | ||
| amiType: "AL2023_ARM_64_STANDARD", |
There was a problem hiding this comment.
Should this instead warn the user to not specify amiType here since it is a no-op, or it actually takes effect in other parts of the system?
There was a problem hiding this comment.
It actually takes effect. This causes the ami id to be set in the launch template
t0yv0
approved these changes
Oct 28, 2024
|
This PR has been shipped in release v3.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an EKS managed NodeGroup with a custom launch template, the AMI type must be removed from the nodegroup itself and instead specified in the launch template.
This did not work if the user specified the AMI type instead of the provider determining it.
This change fixes that by correctly omitting the user defined AMI type as well in that case.
Fixes #1463