Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Enable Upgrade tests #1387

Closed
flostadler opened this issue Sep 25, 2024 · 2 comments · Fixed by #1467
Closed

Re-Enable Upgrade tests #1387

flostadler opened this issue Sep 25, 2024 · 2 comments · Fixed by #1467
Assignees
@flostadler
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@flostadler
Copy link
Contributor

The release branch for EKS v3 contains breaking changes now. This causes the upgrade tests to fail. Because of that we disabled the upgrade tests.
Once the first alpha version was released we can re-record and re-enable them.
@flostadler flostadler added the kind/engineering Work that is not visible to an external user label Sep 25, 2024
@flostadler flostadler self-assigned this Sep 25, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 25, 2024
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3558

@flostadler flostadler removed the needs-triage Needs attention from the triage team label Sep 25, 2024
@flostadler flostadler mentioned this issue Oct 28, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 28, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #1467 and shipped in release v3.0.1.

@blampe blampe mentioned this issue Nov 14, 2024
Merged
blampe added a commit that referenced this issue Nov 14, 2024
@blampe
Move integration tests to ./tests (#1490)
e666a6f 
This consolidates integration tests (currently located in `./examples`
and `./provider`) under `./tests`.

This is prep work for #1474,
and the net result is a clearer distinction between "fast" and "slow"
tests meant to be run during the "prerequisites" and "tests" steps in
CI. Everything under `./provider` can be considered "fast" and
everything under `./tests` can be considered "slow" and worthy of
sharding.

Specifically:
* Everything under `./examples/tests` is moved to
`./tests/testdata/programs` as these were assumed to not be user-facing.
* Upgrade tests under `./provider` are also moved to `./tests` but
tagged in a way that they continue to run as their own job. (These are
the new `upgrade_test.go` and `validation_test.go` files.)
* `examples/utils/utils.go` moves to `tests/internal/utils`.
* `TestEksAuthModeUpgrade` wasn't re-enabled as part of #1387, so I
re-enabled and re-recorded it.
* `go.mod` is consolidated at the repo root to keep dependencies
consistent across the provider and tests. (There are a ton of additional
DX advantages to structuring things this way.) This project is not meant
to be consumed as a library so this is an acceptable breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
No open projects
[Epic] EKS Modernization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable upgrade tests pulumi/pulumi-eks
3 participants
@flostadler @cleverguy25 @pulumi-bot