Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archived photos no longer archived after upgrade - Archive page says Nothing to show here #1347

Open
meonkeys opened this issue Nov 11, 2024 · 3 comments
Labels
needs triage To be triaged

Comments

@meonkeys
Copy link

meonkeys commented Nov 11, 2024

Describe the bug

Photos I have previously archived are no longer archived. They are still in the .archive folder, but they show up on the main timeline (/apps/memories/) and do not show up in Archive (/apps/memories/archive). I think the issue started after I upgraded Nextcloud from 29 to 30--maybe the Memories app got updated as well?

Steps To Reproduce

I can only repro the bug on my self-hosted "production" instance.
I tried running docker run -d -p 8080:80 nextcloud, running initial setup, installing Memories, uploading two photos, archiving one... that worked as expected.

Platform

- OS: nc server is from latest 30.0.2 Docker community image, host is Ubuntu 22.04, client OS is multiple (macos, Linux, Windows)
- DB: mariadb 10.6, args: `--transaction-isolation=READ-COMMITTED --log-bin=binlog --binlog-format=ROW --skip-innodb-read-only-compressed --log_bin_trust_function_creators=true`
- Browser: multiple (Firefox, Chromium, Safari)
- Memories Version: 7.4.1
- Nextcloud Version: 30.0.2
- PHP Version: 8.2.25

Screenshots

/apps/memories/archive on my prod instance:

Screenshot from 2024-11-11 08-46-47

Additional context

  • my Timeline path is /Photos
  • my Folders path is /
  • my archived files are in /Photos/.archive
  • some folders with a .nomedia file are included in the timeline
  • Any errors in the JS console? no
  • Any errors in the Nextcloud server logs? no
@meonkeys meonkeys added the needs triage To be triaged label Nov 11, 2024
@meonkeys
Copy link
Author

I guess I'll try occ memories:index --force. I'm imagining that will correct any inconsistency between photos/videos in Memories tables and as they actually are on disk. Is that correct?

I'm not clear on if this has a chance of fixing whether or not files are considered "archived".

@pulsejet
Copy link
Owner

The archive behavior has not changed at all and simply depends on the folder name (anything named .archive is archive).

What happens if you try to archive something that is already in the .archive folder?

@meonkeys
Copy link
Author

I took another look. It seems like my timeline is displaying photos outside my /Photos timeline path, e.g. /other/folder/test.jpg. I know you didn't suggest this, but I tried archiving test.jpg and it is then moved to /.archive/other/folder/test.jpg. This is a new, second archive path besides my original /Photos/.archive folder. Not sure if that is another issue or related or whatever.

So I was wrong before: I am not seeing photos in /Photos/.archive in my Timeline, so that seems like intended behavior. But I am also not seeing anything when I go to /apps/memories/archive, just the "Nothing to show here" message from my screenshot in the original report.

So I guess the issue is really more that "Timeline path" is no longer working, and /apps/memories/archive is empty? I really wish I could get a clean room repro but so far I've been unsuccessful.

@meonkeys meonkeys changed the title archived photos no longer archived after upgrade archived photos no longer archived after upgrade - Archive page says Nothing to show here Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage To be triaged
Projects
None yet
Development

No branches or pull requests

2 participants