Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APIで操作したアカウントが空になっているのを修正 #596

Merged
merged 10 commits into from
Jul 28, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Jul 27, 2024

What does this PR do?

close #511

  • APIエンドポイントが認証を要求することを明示的に示すように
  • APIドキュメントの更新
  • OpenAPI Specのバージョンを3.0.0から3.1.0へ変更
    • 3.0.0だとAPIリファレンスのページで正しい記載にならないため(ライブラリのバグ?)
  • アクセス/リフレッシュトークンのsubaccountIDに、accountNameを追加
  • それに伴うミドルウェアの更新
  • APIハンドラ側で固定 or 空になっていた操作者アカウントID or アカウント名をトークンから取得したものに置き換え

Additional information

main.ts Show resolved Hide resolved
pkg/accounts/adaptor/repository/prisma.ts Outdated Show resolved Hide resolved
pkg/adaptors/authenticateMiddleware.ts Outdated Show resolved Hide resolved
@laminne laminne requested a review from MikuroXina July 27, 2024 23:26
@laminne laminne enabled auto-merge (squash) July 27, 2024 23:26
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 160 lines in your changes missing coverage. Please review.

Project coverage is 53.25%. Comparing base (b8f3675) to head (860cbc4).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/accounts/router.ts 0.00% 35 Missing ⚠️
pkg/adaptors/authenticateMiddleware.ts 0.00% 22 Missing ⚠️
pkg/notes/router.ts 0.00% 20 Missing ⚠️
pkg/drive/mod.ts 0.00% 18 Missing ⚠️
pkg/notes/mod.ts 0.00% 15 Missing ⚠️
pkg/accounts/mod.ts 0.00% 13 Missing ⚠️
pkg/accounts/adaptor/controller/account.ts 0.00% 12 Missing ⚠️
pkg/timeline/mod.ts 0.00% 10 Missing ⚠️
pkg/timeline/router.ts 0.00% 10 Missing ⚠️
pkg/drive/router.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   53.91%   53.25%   -0.66%     
==========================================
  Files         121      121              
  Lines        8897     9020     +123     
  Branches      796      796              
==========================================
+ Hits         4797     4804       +7     
- Misses       4100     4216     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne requested a review from MikuroXina July 28, 2024 00:55
@laminne laminne requested a review from MikuroXina July 28, 2024 01:36
@laminne laminne merged commit 3400b93 into main Jul 28, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/511-fill-api-account-id branch July 28, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIで操作したユーザーが空になっている部分を修正する
2 participants