Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 可能な限りメソッド/関数が返す値の型をOptionからResultにする #771

Open
laminne opened this issue Oct 18, 2024 · 0 comments
Open

refactor: 可能な限りメソッド/関数が返す値の型をOptionからResultにする #771

laminne opened this issue Oct 18, 2024 · 0 comments
Labels
good first issue Recommended Issue for new contributors P: medium T: refactoring

Comments

@laminne
Copy link
Member

laminne commented Oct 18, 2024

概要

  • Option<T>でTがエラーでないの場合、エラーが発生してもそれを握りつぶす実装になっていることがある
    • 握りつぶすとエラーが判別不可能になり、causeに入らないのでログなどにも出てこない
      → Result<Error, T>を使うようにし、エラーの情報を返すことができるようにする
@laminne laminne assigned laminne and unassigned laminne Oct 31, 2024
@laminne laminne added the good first issue Recommended Issue for new contributors label Oct 31, 2024
@laminne laminne moved this from Todo to Backlog in Pulsate v0.1 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Recommended Issue for new contributors P: medium T: refactoring
Projects
Pulsate v0.1
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laminne