Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: output log from all modules #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: output log from all modules #859

wants to merge 1 commit into from

Conversation

laminne
Copy link
Member

@laminne laminne commented Nov 30, 2024 •
edited
Loading

close #615
close #614

What does this PR do?

  • ロガーの設定
    • 仮でpretty printするようにしました
  • ログを出力するように
    • 実装されているすべてのエンドポイントで以下のエラーが発生した時にログを出力するように
      • エラー発生時
      • 内部エラー発生時(InternalError扱い)

Additional information

@laminne laminne added the T: improvement Improvement of functions, etc. label Nov 30, 2024
@laminne laminne self-assigned this Nov 30, 2024
@laminne laminne enabled auto-merge (squash) November 30, 2024 08:34
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (bb067e3) to head (9acb1f6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/accounts/mod.ts 0.00% 37 Missing ⚠️
pkg/timeline/mod.ts 0.00% 23 Missing ⚠️
pkg/notes/mod.ts 0.00% 15 Missing ⚠️
pkg/accounts/adaptor/logger.ts 0.00% 5 Missing ⚠️
pkg/drive/adaptor/logger.ts 0.00% 5 Missing ⚠️
pkg/federation/adaptor/logger.ts 0.00% 5 Missing ⚠️
pkg/notes/adaptor/logger.ts 0.00% 5 Missing ⚠️
pkg/timeline/adaptor/logger.ts 0.00% 5 Missing ⚠️
pkg/drive/mod.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   49.76%   49.55%   -0.21%     
==========================================
  Files         172      177       +5     
  Lines       15888    16290     +402     
  Branches     1246     1251       +5     
==========================================
+ Hits         7906     8072     +166     
- Misses       7982     8218     +236

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikuroXina MikuroXina Awaiting requested review from MikuroXina

At least 1 approving review is required to merge this pull request.

Assignees

@laminne laminne

Labels
T: improvement Improvement of functions, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ログを出力する feat: 起動時にログ出力を行う
1 participant
@laminne