Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_highest violates content immutability #1550

Open
mdellweg opened this issue Aug 9, 2023 · 2 comments · May be fixed by #2039
Open

is_highest violates content immutability #1550

mdellweg opened this issue Aug 9, 2023 · 2 comments · May be fixed by #2039
Labels
Issue

Comments

@mdellweg
Copy link
Member

mdellweg commented Aug 9, 2023 

          > I'm really not happy, we ignore that content must be immutable. What happens if we remove the uniqueness constraint on the `is_latest` and specifically allow it to be a bit fuzzy at times? A mutable field within a uniqueness constraint seems to be additionally painful. Also what is true for a collection in one repository version does not necessarily be as true in another. Could we move that information elsewhere?

This is how it has been for years... Yes we should refactor it to better be align with Pulp philosophy, not sure how though. For AAH it has been fine to have this field calculated on the model since they only cared about one repository, but with the introduction of repo management it might be time to look at this field again. I think we should file an issue for this and put the design discussion there.

Originally posted by @gerrod3 in #1548 (comment)
@gerrod3 gerrod3 added the Issue label Aug 15, 2023
@webknjaz
Copy link

FTR there's also a race condition related to this: #1571.

@mdellweg
Copy link
Member Author

is_highest was the actual name of the bad field. It's use has been removed.
This issue can conclude with the removal of the field from the database.

@mdellweg mdellweg changed the title is_latest violates content immutability is_highest violates content immutability Nov 20, 2024
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Nov 21, 2024
@mdellweg
Remove deprecated is_highest form CollectionVersion
5f7461f 
fixes pulp#1550
@mdellweg mdellweg linked a pull request Nov 21, 2024 that will close this issue
Remove is highest #2039
Draft
mdellweg added a commit to mdellweg/pulp_ansible that referenced this issue Nov 21, 2024
@mdellweg
Remove deprecated is_highest form CollectionVersion
ae7321e 
fixes pulp#1550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove is highest mdellweg/pulp_ansible
3 participants
@webknjaz @mdellweg @gerrod3