Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAI endpoint erroring #6468

Open
1 task
tpendragon opened this issue Jul 30, 2024 · 1 comment
Open
1 task

OAI endpoint erroring #6468

tpendragon opened this issue Jul 30, 2024 · 1 comment

Comments

@tpendragon
Copy link
Contributor

tpendragon commented Jul 30, 2024

[Figgy/production] NoMethodError: undefined method `alpha3' for nil:NilClass

Acceptance Criteria

  • Records harvested from Pulfalight don't error when you go to the OAI endpoint for them.

Background

Example bad page: https://figgy.princeton.edu/oai?verb=GetRecord&identifier=oai:figgy:b484f4e9-4a69-4de1-93ae-f67fdb9c579a&metadataPrefix=oai_dc

First Step

Write a test.

Backtrace

line 45 of [PROJECT_ROOT]/app/models/oai/figgy/oai_wrapper.rb: language
line 5 of [PROJECT_ROOT]/app/controllers/oai_controller.rb: index

View full backtrace and more info at honeybadger.io

@eliotjordan eliotjordan changed the title [Figgy/production] NoMethodError: undefined method `alpha3' for nil:NilClass OAI endpoint errroring Jul 30, 2024
@tpendragon
Copy link
Contributor Author

tpendragon commented Aug 7, 2024

I looked at this briefly:

I think the language codes for resources have changed to include multiple languages, but we're importing them as one. For example, https://findingaids.princeton.edu/catalog/C0022_c0145.json used to have a language of "English", but now it's "English French" - because it's actually two languages.

It looks like finding aids may even be indexing them as a single field:

{
"language_ssm": "English French"
}

@hackartisan hackartisan changed the title OAI endpoint errroring OAI endpoint erroring Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants