Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky feature tests #1165

Open
1 of 4 tasks
sandbergja opened this issue Aug 12, 2024 · 2 comments
Open
1 of 4 tasks

Fix flaky feature tests #1165

sandbergja opened this issue Aug 12, 2024 · 2 comments

Comments

@sandbergja
Copy link
Member

sandbergja commented Aug 12, 2024

What maintenance needs to be done?

Make the following tests more reliable and consistent:

rspec ./spec/features/report_spec.rb:17 # My Requests I can filter reports
rspec ./spec/features/my_requests_spec.rb:12 # My Requests I can filter my requests
rspec ./spec/features/my_requests_spec.rb:54 # My Requests I can sort my requests

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

This test sometimes passes and sometimes fails in CI, so it's hard to tell whether or not this feature is working.

Acceptance criteria

  • This test passes reliably, without having to rerun it

Notes

This might be related to the select_drop_down custom test method.

This custom test method may not wait for the javascript to render, or might not see hidden elements on the page. It would be nice if we could use the capybara #select matcher for these tests.

@kevinreiss kevinreiss added this to the Rails Application Sprint milestone Aug 13, 2024
@maxkadel maxkadel self-assigned this Sep 19, 2024
@kevinreiss
Copy link
Member

This issue is the select version of this issue in LUX pulibrary/lux-design-system#225.

@maxkadel maxkadel changed the title report_spec.rb has a flaky test: "My Requests I can filter reports" Fix flaky feature tests Sep 19, 2024
@maxkadel
Copy link
Contributor

Blocked by pulibrary/lux-design-system#348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants