Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception on history unencrypted message #175

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

seba-aln
Copy link
Contributor

@seba-aln seba-aln commented Nov 22, 2023

fix: Gracefully handle decrypting an unencrypted method. If a decryption error occurs when trying to decrypt plain text, the plain text message will be returned and an error field will be set in the response. This works for both history and subscription messages.

@seba-aln
Copy link
Contributor Author

@pubnub-release-bot release

Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seba-aln seba-aln merged commit 57360f2 into master Nov 27, 2023
9 checks passed
@seba-aln seba-aln deleted the crypto/no-fail-on-decoded-message branch November 27, 2023 09:42
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants