Strongly typed endpoint output #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seba-aln
force-pushed
the
refactor/typing-for-common-stuff
branch
from
0110fd7 to
ecdf8e5
Compare
marcin-cebo
approved these changes
Jul 3, 2024
| @@ -88,7 +87,7 @@ protected function httpMethod() | |||
| /** | |||
| * @return PNAccessManagerAuditResult | |||
There was a problem hiding this comment.
Is this comment need when a type is defined?
There was a problem hiding this comment.
I'll include it in future PR
| { | ||
| return PNGetChannelMetadataResult::fromPayload($result); | ||
| } | ||
|
|
||
| public function sync(): PNGetChannelMetadataResult | ||
| { |
There was a problem hiding this comment.
In src/PubNub/Endpoints/Objects/Channel/GetAllChannelMetadata.php there is different formatting. Sth like this:
public function sync(): PNGetChannelMetadataResult {
return parent::sync();
}
Shouldn't it be consistent?
There was a problem hiding this comment.
fixed. the correct way is the opening bracket for a class or function in newline, for conditionals in same line after a single space.
There was a problem hiding this comment.
Did you commit this fix? I can see only one commit - initial one.
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
techwritermat
approved these changes
Jul 10, 2024
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Added strict typing for some customer facing elements