From de0b4dd30e6c11c3d8cf7e669ff015f11a860f1a Mon Sep 17 00:00:00 2001 From: Sebastian Molenda Date: Mon, 21 Oct 2024 15:58:31 +0200 Subject: [PATCH] fix typo in pubnub.yaml and bump php in test matrix --- .github/workflows/run-tests.yml | 2 +- .pubnub.yml | 6 +++--- examples/GrantToken.php | 1 - src/PubNub/Endpoints/Access/GrantToken.php | 6 ++---- .../Consumer/FileSharing/PNGetFileDownloadURLResult.php | 1 - 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ef51f81..81f5a44 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -19,7 +19,7 @@ jobs: max-parallel: 1 fail-fast: true matrix: - php: [8.0, 8.1, 8.2] + php: [8,1, 8.2, 8.3] env: PUBLISH_KEY: ${{ secrets.SDK_PUB_KEY }} SUBSCRIBE_KEY: ${{ secrets.SDK_SUB_KEY }} diff --git a/.pubnub.yml b/.pubnub.yml index 653f5df..45721e9 100644 --- a/.pubnub.yml +++ b/.pubnub.yml @@ -325,7 +325,7 @@ sdks: minimum-os-version: - Mac OS X 10.8 maximum-os-version: - - macOS 15 + - macOS 15.0.1 target-architecture: - arm64 - x86-64 @@ -387,7 +387,7 @@ sdks: minimum-os-version: - Mac OS X 10.8 maximum-os-version: - - macOS 15 + - macOS 15.0.1 target-architecture: - arm64 - x86-64 @@ -449,7 +449,7 @@ sdks: minimum-os-version: - Mac OS X 10.8 maximum-os-version: - - macOS 15 + - macOS 15.0.1 target-architecture: - arm64 - x86-64 diff --git a/examples/GrantToken.php b/examples/GrantToken.php index 8eafd63..71517fe 100644 --- a/examples/GrantToken.php +++ b/examples/GrantToken.php @@ -33,7 +33,6 @@ print("Token TTL: $tokensTTL\n"); print("Token My Channel Read: " . (int)$tokensMyChannelRead . "\n"); print("Token My Channel Write: " . (int)$tokensMyChannelWrite . "\n"); - } catch (\PubNub\Exceptions\PubNubServerException $e) { var_dump($e->getBody()); } diff --git a/src/PubNub/Endpoints/Access/GrantToken.php b/src/PubNub/Endpoints/Access/GrantToken.php index e128db6..a9d7afe 100644 --- a/src/PubNub/Endpoints/Access/GrantToken.php +++ b/src/PubNub/Endpoints/Access/GrantToken.php @@ -2,7 +2,6 @@ namespace PubNub\Endpoints\Access; - use PubNub\Endpoints\Endpoint; use PubNub\Exceptions\PubNubValidationException; use PubNub\PubNubUtil; @@ -12,7 +11,6 @@ use PubNub\Models\Consumer\AccessManager\PNAccessManagerTokenResult; use PubNub\PubNubCborDecode; - class GrantToken extends Endpoint { protected const PATH = '/v3/pam/%s/grant'; @@ -240,7 +238,7 @@ public function buildPath() /** * @return string */ - public function sync() : string + public function sync(): string { return parent::sync(); } @@ -249,7 +247,7 @@ public function sync() : string * @param string $token * @return string */ - public function createResponse($response) : string + public function createResponse($response): string { return $response['data']['token']; } diff --git a/src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php b/src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php index 2339b17..54b0fe6 100644 --- a/src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php +++ b/src/PubNub/Models/Consumer/FileSharing/PNGetFileDownloadURLResult.php @@ -2,7 +2,6 @@ namespace PubNub\Models\Consumer\FileSharing; - class PNGetFileDownloadURLResult { protected string $fileUrl;