Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace <= with : into regex #162

Merged
merged 2 commits into from
May 22, 2024

Conversation

gitmazzio
Copy link
Contributor

@gitmazzio gitmazzio commented May 13, 2024

Hi all,

I noticed that using js-chat caused a blank page on my nextjs project. I investigate and the regex throw Invalid regular expression: invalid group specifier name error. Here's the fix!

@piotr-suwala
Copy link
Contributor

piotr-suwala commented May 13, 2024

Hello @gitmazzio!

We're investigating the problem. We'll take a look at this PR in the upcoming days.

@piotr-suwala
Copy link
Contributor

Hello @gitmazzio.
I checked your changes and unfortunately certain unit tests didn't pass. I allowed myself push a new commit with another regex (without look behind and with passing all tests) to your fork and branch. Can you take a look and check if my recent change here works in your application on that old Safari?

Thanks
Piotr

@gitmazzio
Copy link
Contributor Author

Hello @gitmazzio. I checked your changes and unfortunately certain unit tests didn't pass. I allowed myself push a new commit with another regex (without look behind and with passing all tests) to your fork and branch. Can you take a look and check if my recent change here works in your application on that old Safari?

Thanks Piotr

hi @piotr-suwala,

it works also for old safari version!

Copy link
Contributor

@piotr-suwala piotr-suwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piotr-suwala piotr-suwala merged commit 8e20c79 into pubnub:master May 22, 2024
@piotr-suwala
Copy link
Contributor

@gitmazzio merged and deployed. Available under 0.7.0 👍 . Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants