Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in latest code to resolve before publishing to live site #1128

Open
1 of 4 tasks
jywarren opened this issue Dec 5, 2019 · 4 comments
Open
1 of 4 tasks

Errors in latest code to resolve before publishing to live site #1128

jywarren opened this issue Dec 5, 2019 · 4 comments

Comments

@jywarren
Copy link
Member

jywarren commented Dec 5, 2019

Hi! I'm just getting things closer to a new release we can publish to the live site, and writing down a variety of small bugs I found that I think need to be addressed before this is ready to publish. I'm sure we can do this!

image

Finally, I think some tools (scale, simple rotate (not free rotate), and drag) should be hidden or tucked into a submenu, as they're not critical and make the menu a little overwhelming for newcomers.

I'd love help figuring these out, and then we can get closer to publishing this to the live site!

You can try this all out here:

http://mapknitter-stable.laboratoriopublico.org/maps/lee-nh/edit

@jywarren
Copy link
Member Author

jywarren commented Dec 5, 2019

Linking to publiclab/Leaflet.DistortableImage#471 for Add prompt for multi-export scale AND/OR allow setting this in DistortableCollection constructor

@sashadev-sky
Copy link
Member

@jywarren

  1. prompt: we never set a prompt to my knowledge
  2. zoom : on the link you provided the map goes up to 18 zoom for me (map.getZoom() in console). also looks about the same zoom in the screenshot you attached? This is set from this file: https://github.com/publiclab/Leaflet.DistortableImage/blob/main/src/mapmixins/MapMixins.js
    we let it go up to 21 if you set that but the default is 18.
  3. anything else in particular you noticed about the newly placed images when bug did happen vs didnt?

@jywarren
Copy link
Member Author

jywarren commented Dec 5, 2019

Thanks @sashadev-sky!

re Prompt I posted at publiclab/Leaflet.DistortableImage#471 -- thanks!

Re zoom - here is a post about it - i was underestimating, it's actually max zoom 24!

I'm going to make a new issue about it and I think it can also be a great GCI task - pretty simple!

@jywarren
Copy link
Member Author

jywarren commented Dec 5, 2019

Moved the zoom one to publiclab/Leaflet.DistortableImage#473 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants