Fix bugs caused by layer id conflict #443
Conversation
|
I caught another weird bug where the OIM layers from one map were interfering with the OIM layers in the other map and removed the error icons from other layers in the first map when one of the OIM layers were clicked. This has also been fixed. |
| @@ -61,6 +37,31 @@ L.LayerGroup.environmentalLayers = L.LayerGroup.extend( | |||
|
|
|||
| this.options.layers = param; | |||
|
|
|||
| this._OpenInfraMap_Power = L.tileLayer('https://tiles-{s}.openinframap.org/power/{z}/{x}/{y}.png', { | |||
There was a problem hiding this comment.
I am a bit worried about moving these layers here but this seems to fix the issue of cross-wiring between layers when we have multiple maps on the page as mentioned here #443 (comment)
It's hard to test how these layers behave when added to the map because they don't work anymore. We could also comment them out till it is fixed.
There was a problem hiding this comment.
Ah ok -- and noting #387 as the bug to fix for that. Thanks!
|
There are a couple of failing tests. I'll look into them fixed later tonight or tomorrow. |
crisner
force-pushed
the
fix-bugs-caused-by-layer-id-conflict
branch
from
a1e7dc3
to
d2d4e3e
Compare
crisner
changed the title
crisner
force-pushed
the
fix-bugs-caused-by-layer-id-conflict
branch
from
eee9ce2
to
27f5e73
Compare
|
|
crisner
changed the title
|
@jywarren, @sagarpreet-chadha, this PR fixes bugs from recent changes, fixes tests that were causing errors in the master branch and is ready for review and merge. Thanks! |
crisner
force-pushed
the
fix-bugs-caused-by-layer-id-conflict
branch
from
27f5e73
to
1d39d9c
Compare
|
Great work!! |
|
Thank you!!! |
Fixes #442 (<=== Add issue number here) &&
Fixes #441
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!